From: Andi Kleen <ak@suse.de>
To: Roland Dreier <rdreier@cisco.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>,
Adrian Bunk <bunk@stusta.de>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [patch] disable NMI watchdog by default
Date: Wed, 7 Mar 2007 15:56:49 +0100 [thread overview]
Message-ID: <200703071556.49547.ak@suse.de> (raw)
In-Reply-To: <ada1wk1ycod.fsf@cisco.com>
On Wednesday 07 March 2007 04:06, Roland Dreier wrote:
> > --- linux.orig/include/asm-x86_64/nmi.h
> > +++ linux/include/asm-x86_64/nmi.h
> > @@ -63,7 +63,7 @@ extern int setup_nmi_watchdog(char *);
> >
> > extern atomic_t nmi_active;
> > extern unsigned int nmi_watchdog;
> > -#define NMI_DEFAULT -1
> > +#define NMI_DEFAULT 0
>
> Maybe I'm missing something obvious, but this patch doesn't seem
> correct to me. The sentiment of disabling the NMI watchdog by default
> is fine, and I agree with it, but I don't think this patch does what
> it says. First of all, I have a system running a kernel with this
> patch applied (v2.6.21-rc2-gc3442e2), and I see NMIs in
> /proc/interrupts and "testing NMI watchdog ... OK." in the log.
Yes the patch looks quite broken.
-Andi
next prev parent reply other threads:[~2007-03-07 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 12:20 [patch] disable NMI watchdog by default Ingo Molnar
2007-03-05 14:49 ` Arjan van de Ven
2007-03-05 17:42 ` Len Brown
2007-03-05 19:54 ` Andi Kleen
2007-03-05 20:26 ` Ingo Molnar
2007-03-05 20:40 ` Linus Torvalds
2007-03-07 3:06 ` Roland Dreier
2007-03-07 14:56 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-01-14 9:29 Ingo Molnar
2007-01-14 14:45 ` Henrique de Moraes Holschuh
2007-01-14 16:45 ` Arjan van de Ven
2007-03-05 16:02 ` Bill Davidsen
2007-03-08 19:44 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703071556.49547.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdreier@cisco.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox