From: Christoph Hellwig <hch@lst.de>
To: Michael Nishimoto <miken@agami.com>
Cc: Christoph Hellwig <hch@lst.de>,
xfs@oss.sgi.com, ecashin@coraid.com, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr
Date: Wed, 7 Mar 2007 18:15:47 +0100 [thread overview]
Message-ID: <20070307171547.GA22641@lst.de> (raw)
In-Reply-To: <45EEF0B5.40905@agami.com>
On Wed, Mar 07, 2007 at 09:04:53AM -0800, Michael Nishimoto wrote:
> Incore log buffers are not always a power of two of the page size.
> In particular, when xfs is running over software raid devices, the
> log buffers are allocated to match the size of a stripe.
>
> However, they are always a multiple of PAGE_SIZE, so we are still safe.
It's not actually about beeing safe - any allocation is still safe
with this patch. The issue is just that we waste memory because
we round up allocations to the next page size.
The power of two bit is actually wrong in this mail, it was about
another optimization I have that needs some more testing first.
next prev parent reply other threads:[~2007-03-07 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 10:13 [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr Christoph Hellwig
2007-03-07 12:14 ` Shailendra Tripathi
2007-03-07 12:38 ` Christoph Hellwig
2007-03-07 17:04 ` Michael Nishimoto
2007-03-07 17:15 ` Christoph Hellwig [this message]
2007-03-09 11:55 ` Christoph Hellwig
2007-03-13 0:08 ` Timothy Shimmin
2007-03-17 0:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307171547.GA22641@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=ecashin@coraid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miken@agami.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox