From: Matt Mackall <mpm@selenic.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
akpm@osdl.org, Marcelo Tosatti <marcelo@kvack.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Manfred Spraul <manfred@colorfullife.com>
Subject: Re: [SLUB 2/3] Large kmalloc pass through. Removal of large general slabs
Date: Wed, 7 Mar 2007 12:03:59 -0600 [thread overview]
Message-ID: <20070307180359.GU23311@waste.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0703070732130.9460@schroedinger.engr.sgi.com>
On Wed, Mar 07, 2007 at 07:34:38AM -0800, Christoph Lameter wrote:
> On Wed, 7 Mar 2007, Peter Zijlstra wrote:
>
> > > return -1;
> > > }
> >
> > Perhaps so something with PAGE_SIZE here, as you know there are
> > platforms/configs where PAGE_SIZE != 4k :-)
>
> Any allocation > 2k just uses a regular allocation which will waste space.
>
> I have a patch here to make this dependent on page size using a loop. The
> problem is that it does not work with some versions of gcc. On the
> other hand we really need this since one arch can
> actually have an order 22 page size!
You don't need a loop, you need an if (s >= PAGE_SIZE) at the head of
your static list.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2007-03-07 18:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 2:35 [SLUB 0/3] SLUB: The unqueued slab allocator V4 Christoph Lameter
2007-03-07 2:35 ` [SLUB 1/3] SLUB core Christoph Lameter
2007-03-07 2:35 ` [SLUB 2/3] Large kmalloc pass through. Removal of large general slabs Christoph Lameter
2007-03-07 2:40 ` Matt Mackall
2007-03-07 3:22 ` Christoph Lameter
2007-03-07 9:01 ` Peter Zijlstra
2007-03-07 15:34 ` Christoph Lameter
2007-03-07 18:03 ` Matt Mackall [this message]
2007-03-07 18:23 ` Christoph Lameter
2007-03-07 2:35 ` [SLUB 3/3] Guarantee minimum number of objects in a slab Christoph Lameter
2007-03-08 10:54 ` [SLUB 0/3] SLUB: The unqueued slab allocator V4 Mel Gorman
2007-03-08 16:48 ` Christoph Lameter
2007-03-08 17:40 ` Mel Gorman
2007-03-08 18:16 ` Christoph Lameter
2007-03-09 13:55 ` Mel Gorman
2007-03-08 21:54 ` Christoph Lameter
2007-03-09 14:00 ` Mel Gorman
2007-03-09 16:40 ` Christoph Lameter
2007-03-09 15:06 ` Mel Gorman
2007-03-09 17:21 ` Christoph Lameter
2007-03-08 17:46 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307180359.GU23311@waste.org \
--to=mpm@selenic.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manfred@colorfullife.com \
--cc=marcelo@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox