From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992435AbXCGSRz (ORCPT ); Wed, 7 Mar 2007 13:17:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2992438AbXCGSRy (ORCPT ); Wed, 7 Mar 2007 13:17:54 -0500 Received: from waste.org ([66.93.16.53]:40972 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992437AbXCGSRx (ORCPT ); Wed, 7 Mar 2007 13:17:53 -0500 Date: Wed, 7 Mar 2007 12:03:59 -0600 From: Matt Mackall To: Christoph Lameter Cc: Peter Zijlstra , akpm@osdl.org, Marcelo Tosatti , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Manfred Spraul Subject: Re: [SLUB 2/3] Large kmalloc pass through. Removal of large general slabs Message-ID: <20070307180359.GU23311@waste.org> References: <20070307023502.19658.39217.sendpatchset@schroedinger.engr.sgi.com> <20070307023513.19658.81228.sendpatchset@schroedinger.engr.sgi.com> <1173258077.6374.120.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 07, 2007 at 07:34:38AM -0800, Christoph Lameter wrote: > On Wed, 7 Mar 2007, Peter Zijlstra wrote: > > > > return -1; > > > } > > > > Perhaps so something with PAGE_SIZE here, as you know there are > > platforms/configs where PAGE_SIZE != 4k :-) > > Any allocation > 2k just uses a regular allocation which will waste space. > > I have a patch here to make this dependent on page size using a loop. The > problem is that it does not work with some versions of gcc. On the > other hand we really need this since one arch can > actually have an order 22 page size! You don't need a loop, you need an if (s >= PAGE_SIZE) at the head of your static list. -- Mathematics is the supreme nostalgia of our time.