From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>, stable@kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Blaisorblade <blaisorblade@yahoo.it>
Subject: [PATCH] UML - arch_prctl should set thread fs
Date: Wed, 7 Mar 2007 14:01:00 -0500 [thread overview]
Message-ID: <20070307190100.GA3847@ccure.user-mode-linux.org> (raw)
[ Andrew, this is definite 2.6.21 material ]
In my previous x86_64 thread fix, I forgot to initialize
thread.arch.fs in arch_prctl. A process calling arch_prctl to set %fs
would lose it on the next context switch.
It also turns out that you can switch to a process which is in the
process of exiting and which has lost its mm. In this case, it's
worse than useless to try to call arch_prctl on the host process.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
arch/um/sys-x86_64/syscalls.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Index: linux-2.6.18-mm/arch/um/sys-x86_64/syscalls.c
===================================================================
--- linux-2.6.18-mm.orig/arch/um/sys-x86_64/syscalls.c 2007-03-07 12:05:02.000000000 -0500
+++ linux-2.6.18-mm/arch/um/sys-x86_64/syscalls.c 2007-03-07 14:01:16.000000000 -0500
@@ -103,6 +103,9 @@ long arch_prctl_skas(struct task_struct
switch(code){
case ARCH_SET_FS:
+ current->thread.arch.fs = (unsigned long) ptr;
+ save_registers(pid, ¤t->thread.regs.regs);
+ break;
case ARCH_SET_GS:
save_registers(pid, ¤t->thread.regs.regs);
break;
@@ -140,9 +143,8 @@ long sys_clone(unsigned long clone_flags
void arch_switch_to_skas(struct task_struct *from, struct task_struct *to)
{
- if(to->thread.arch.fs == 0)
+ if((to->thread.arch.fs == 0) || (to->mm == NULL))
return;
arch_prctl_skas(to, ARCH_SET_FS, (void __user *) to->thread.arch.fs);
}
-
next reply other threads:[~2007-03-07 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 19:01 Jeff Dike [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-03-16 16:10 [PATCH] UML - arch_prctl should set thread fs Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307190100.GA3847@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox