From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity
Date: Thu, 8 Mar 2007 09:02:28 +0100 [thread overview]
Message-ID: <20070308080228.GK3441@stusta.de> (raw)
In-Reply-To: <20070307150057.4e6342dc.akpm@linux-foundation.org>
On Wed, Mar 07, 2007 at 03:00:57PM -0800, Andrew Morton wrote:
> On Wed, 7 Mar 2007 23:41:16 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > On Tue, Mar 06, 2007 at 12:44:08AM -0800, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.20-rc2-mm1:
> > >...
> > > git-netdev-all.patch
> > >...
> > > git trees
> > >...
> >
> > drivers/net/wireless/libertas/debugfs.c contains:
> > #define item_addr(n) ((u32) &((wlan_adapter *)0)->n)
> >
> > This is wrong on 64bit architectures.
>
> Is OK - it is simply yet another reimplementation of offsetof(). Hint.
Thanks for the correction - it seems C pointers and me will never become
close friends...
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-03-08 8:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 8:44 2.6.21-rc2-mm2 Andrew Morton
2007-03-06 9:06 ` 2.6.21-rc2-mm2 J.A. Magallón
2007-03-06 9:15 ` 2.6.21-rc2-mm2 Andrew Morton
2007-03-06 9:38 ` 2.6.21-rc2-mm2 J.A. Magallón
2007-03-06 9:42 ` 2.6.21-rc2-mm2 Andrew Morton
2007-03-06 9:44 ` 2.6.21-rc2-mm2 J.A. Magallón
2007-03-06 11:14 ` 2.6.21-rc2-mm2 Jens Axboe
2007-03-06 10:27 ` 2.6.21-rc2-mm2 KAMEZAWA Hiroyuki
2007-03-06 11:09 ` 2.6.21-rc2-mm2 Andrew Morton
2007-03-06 11:35 ` 2.6.21-rc2-mm2 KAMEZAWA Hiroyuki
2007-03-07 6:23 ` [BUGFIX][PATCH] fix NULL pointer in ia64/irq_chip-mask/unmask function KAMEZAWA Hiroyuki
2007-03-07 6:57 ` Andrew Morton
2007-03-07 7:32 ` KAMEZAWA Hiroyuki
2007-03-08 8:41 ` 2.6.21-rc2-mm2 Magnus Damm
2007-03-06 11:58 ` 2.6.21-rc2-mm2 Con Kolivas
2007-03-06 12:52 ` 2.6.21-rc2-mm2 Thomas Gleixner
2007-03-06 13:24 ` 2.6.21-rc2-mm2 Con Kolivas
2007-03-06 14:47 ` 2.6.21-rc2-mm2 Thomas Gleixner
2007-03-06 20:19 ` 2.6.21-rc2-mm2 Con Kolivas
2007-03-06 15:46 ` 2.6.21-rc2-mm2 J.A. Magallón
2007-03-07 6:24 ` 2.6.21-rc2-mm2 Jean Delvare
2007-03-07 8:39 ` 2.6.21-rc2-mm2 Sébastien Dugué
2007-03-07 8:49 ` 2.6.21-rc2-mm2 Andrew Morton
2007-03-07 9:30 ` 2.6.21-rc2-mm2 Sébastien Dugué
2007-03-07 19:46 ` 2.6.21-rc2-mm2 Luiz Fernando N. Capitulino
2007-03-07 19:52 ` 2.6.21-rc2-mm2 Andrew Morton
2007-03-08 7:20 ` 2.6.21-rc2-mm2 Mike Galbraith
2007-03-07 22:12 ` 2.6.21-rc2-mm2 hang Dave Hansen
2007-03-07 22:46 ` Andrew Morton
[not found] ` <20070307221628.GD26473@linux-os.sc.intel.com>
2007-03-07 23:07 ` Dave Hansen
2007-03-07 23:16 ` Andrew Morton
2007-03-08 15:07 ` Michal Piotrowski
2007-03-08 1:07 ` Siddha, Suresh B
2007-03-07 22:41 ` [RFC: -mm patch] #if 0 mmc_deselect_cards() Adrian Bunk
2007-03-08 5:47 ` Pierre Ossman
2007-03-19 9:21 ` [-mm patch] remove mmc_deselect_cards() Adrian Bunk
2007-03-08 6:31 ` MMC: Fix typo in mmc highspeed Kyungmin Park
2007-03-07 22:41 ` 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity Adrian Bunk
2007-03-07 23:00 ` Andrew Morton
2007-03-08 8:02 ` Adrian Bunk [this message]
2007-03-09 2:11 ` Tony Breeds
2007-03-09 14:19 ` John W. Linville
2007-03-09 17:14 ` Randy Dunlap
2007-03-12 3:43 ` Tony Breeds
2007-03-08 0:03 ` e1000 oops on boot [Re: 2.6.21-rc2-mm2] J.A. Magallón
2007-03-08 0:23 ` Andrew Morton
2007-03-08 0:28 ` Randy Dunlap
2007-03-08 0:35 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070308080228.GK3441@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox