From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751385AbXCHLny (ORCPT ); Thu, 8 Mar 2007 06:43:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751408AbXCHLny (ORCPT ); Thu, 8 Mar 2007 06:43:54 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:39417 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751385AbXCHLnx (ORCPT ); Thu, 8 Mar 2007 06:43:53 -0500 Date: Thu, 8 Mar 2007 12:43:35 +0100 From: Pavel Machek To: Vivek Goyal Cc: linux kernel mailing list , Reloc Kernel List , ebiederm@xmission.com, akpm@linux-foundation.org, ak@suse.de, hpa@zytor.com, magnus.damm@gmail.com, lwang@redhat.com, dzickus@redhat.com, rjw@sisk.pl Subject: Re: [PATCH 11/20] x86_64: wakeup.S misc cleanups Message-ID: <20070308114335.GD5953@elf.ucw.cz> References: <20070307065703.GA23412@in.ibm.com> <20070307071320.GL23412@in.ibm.com> <20070307224157.GD5956@elf.ucw.cz> <20070308042908.GD6000@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070308042908.GD6000@in.ibm.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > > + movw $0x0e00 + 'i', %ds:(0xb8012) > > > + movb $0xa8, %al ; outb %al, $0x80; > > > + > > > > > - movw $0x0e00 + 'i', %ds:(0xb8012) > > > - movb $0xa8, %al ; outb %al, $0x80; > > > > Outbs were my debugging hacks, perhaps you can simply remove them at > > this point? Not sure how useful "Linux" debug print is, it can > > probably be removed, too. > > > > Hi Pavel, > > I found these debugging hacks useful while debugging some problem with > my changes in this code. It helps to find out till what poing code flow > as reached in this assembly code. So I think its not a bad idea to let > this piece code be there. Ok. (I was not sure how common are displays of port 0x80). -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html