From: Jens Axboe <jens.axboe@oracle.com>
To: Thibaut VARENE <T-Bone@parisc-linux.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make elv_register() output atomic
Date: Thu, 8 Mar 2007 14:42:00 +0100 [thread overview]
Message-ID: <20070308134200.GI9671@kernel.dk> (raw)
In-Reply-To: <20070308140608.2b034013@Alucard.r3z0>
On Thu, Mar 08 2007, Thibaut VARENE wrote:
> Hi,
>
> Booting 2.6.21-rc3-g45592145 I noticed the following on one of my
> machines in the bootlog:
>
> io scheduler noop registered<6>Time: jiffies clocksource has been installed.
>
> io scheduler deadline registered (default)
>
>
> Looking at block/elevator.c, it appears that elv_register() uses two
> consecutive printks in a non-atomic way, leading to the above glitch. The
> attached trivial patch fixes this issue, by using a single printk.
Thanks, looks like a good fix!
--
Jens Axboe
prev parent reply other threads:[~2007-03-08 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 13:06 [PATCH] make elv_register() output atomic Thibaut VARENE
2007-03-08 13:42 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070308134200.GI9671@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=T-Bone@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox