From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030823AbXCHWge (ORCPT ); Thu, 8 Mar 2007 17:36:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030812AbXCHWge (ORCPT ); Thu, 8 Mar 2007 17:36:34 -0500 Received: from ns1.suse.de ([195.135.220.2]:57967 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030823AbXCHWgd (ORCPT ); Thu, 8 Mar 2007 17:36:33 -0500 From: Andi Kleen Organization: SUSE Linux Products GmbH, Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg) To: Tom Rini Subject: Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n' Date: Thu, 8 Mar 2007 23:36:14 +0100 User-Agent: KMail/1.9.5 Cc: Dave Jiang , linux-kernel@vger.kernel.org, sshtylyov@ru.mvista.com References: <20070307204516.GA24095@blade.az.mvista.com> <200703081937.56167.ak@suse.de> <20070308184940.GP11626@smtp.west.cox.net> In-Reply-To: <20070308184940.GP11626@smtp.west.cox.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703082336.14436.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 08 March 2007 19:49, Tom Rini wrote: > On Thu, Mar 08, 2007 at 07:37:56PM +0100, Andi Kleen wrote: > > On Thursday 08 March 2007 18:44, Dave Jiang wrote: > > > > > In spite of kgdb, shouldn't it have that \n anyways in case some other code > > > gets added in the future after the macro? Or are you saying that there should > > > never be any code ever after that macro? > > > > Sure if there is mainline code added after that macro we add the \n. > > But only if it makes sense to add code there, which it didn't in kgdb. > > Was that because with recent enough tools and config options there was > enough annotations so GDB could finally figure out where things had > stopped? The x86 kernels are fully dwarf2 annotiated yes. -Andi