From: Jean Delvare <khali@linux-fr.org>
To: "Sonic Zhang" <sonic.adi@gmail.com>
Cc: "Bryan Wu" <bryan.wu@analog.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Alexey Dobriyan" <adobriyan@gmail.com>,
"Mike Frysinger" <vapier.adi@gmail.com>,
linux-kernel@vger.kernel.org, mhfan@ustc.edu
Subject: Re: [PATCH -mm] Blackfin: blackfin i2c driver
Date: Fri, 9 Mar 2007 10:47:06 +0100 [thread overview]
Message-ID: <20070309104706.53ea82ba.khali@linux-fr.org> (raw)
In-Reply-To: <4e5ebad50703082004s6cd34ccbp34e6f8b2c2273389@mail.gmail.com>
On Fri, 9 Mar 2007 12:04:59 +0800, Sonic Zhang wrote:
> On 3/8/07, Jean Delvare <khali@linux-fr.org> wrote:
> > i2c-core can emulate SMBus transactions using master_xfer, so in
> > general when you have a complete master_xfer implementation you do not
> > need to define a separate smbus_xfer function. This would save a lot of
> > code.
>
> Actually the i2c-core can't emulate SMBus transactions using the
> master_xfer function, because the blackfin TWI controller provide
> hardware support to the SMBus transactions and the combination of
> master_xfer operations can't generate proper signal for SMBus.
Did you try? I can't think of any valid reason why it wouldn't work.
All SMBus transactions are compatible with I2C by definition.
Now performance might be better with dedicated code if the hardware
accelerate SMBus transactions, that's a different issue. If you prefer
to keep the smbus_xfer method for performance reasons, that's OK with
me. After all you're the one who will have to maintain the driver ;)
--
Jean Delvare
next prev parent reply other threads:[~2007-03-09 9:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 6:54 [PATCH -mm] Blackfin: blackfin i2c driver Wu, Bryan
2007-03-06 7:18 ` Andrew Morton
2007-03-07 5:17 ` Sonic Zhang
2007-03-07 6:06 ` Andrew Morton
2007-03-07 6:38 ` Wu, Bryan
2007-03-06 21:43 ` Alexey Dobriyan
2007-03-06 23:04 ` Mike Frysinger
2007-03-07 5:57 ` Wu, Bryan
2007-03-07 6:58 ` Jean Delvare
2007-03-07 7:14 ` Andrew Morton
2007-03-07 7:39 ` Wu, Bryan
2007-03-07 7:45 ` Andrew Morton
2007-03-08 3:57 ` trailing whitespace killing (Re: [PATCH -mm] Blackfin: blackfin i2c driver) Oleg Verych
2007-03-08 7:35 ` [PATCH -mm] Blackfin: blackfin i2c driver Jean Delvare
2007-03-07 9:53 ` Wu, Bryan
2007-03-08 9:27 ` Jean Delvare
2007-03-09 4:04 ` Sonic Zhang
2007-03-09 9:47 ` Jean Delvare [this message]
2007-03-07 7:02 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070309104706.53ea82ba.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhfan@ustc.edu \
--cc=sonic.adi@gmail.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox