From: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
To: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org, Michael Halcrow <mhalcrow@us.ibm.com>
Subject: Re: [PATCH 1/2] eCryptfs: convert lookup_one_len() to lookup_one_len_nd()
Date: Fri, 9 Mar 2007 11:34:15 -0500 [thread overview]
Message-ID: <20070309163415.GA21427@filer.fsl.cs.sunysb.edu> (raw)
In-Reply-To: <20070309094000.GA28599@infradead.org>
On Fri, Mar 09, 2007 at 09:40:00AM +0000, Christoph Hellwig wrote:
> On Sat, Feb 17, 2007 at 03:56:55AM -0500, Josef 'Jeff' Sipek wrote:
> > From: Michael Halcrow <mhalcrow@us.ibm.com>
> >
> > Call the new lookup_one_len_nd() rather than lookup_one_len(). This fixes an
> > oops when stacked on NFS.
> >
> > Note that there are still some issues with eCryptfs on NFS having to do with
> > directory deletion (I'm not getting an oops, just an -EBUSY).
>
> Biug NACK here. This is just working around the broken lookup intents
> code. lookup_one_len still is a hack for some network filesystems that
> unfortunately grew a few too many users.
I'm working on the 4-th case to do_path_lookup. The only problem left, is
the negative dentries. do_path_lookup returns -ENOENT. Which would means
that we need either a wrapper that returns the negative dentry instead of
> Implementing this might be a good idea anyway to clean up the mess
> do_path_lookup is currently.
Clean up? There are 4 (including the new case) "setup" cases, and then the
actual lookup happens. You'll need the crazy if conditions unless the mening
of the arguments changes.
Josef "Jeff" Sipek.
--
UNIX is user-friendly ... it's just selective about who it's friends are
next prev parent reply other threads:[~2007-03-09 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-17 8:56 [GIT PULL -mm] Unionfs/eCryptfs cleanups Josef 'Jeff' Sipek
2007-02-17 8:56 ` [PATCH 1/2] eCryptfs: convert lookup_one_len() to lookup_one_len_nd() Josef 'Jeff' Sipek
2007-03-09 9:40 ` Christoph Hellwig
2007-03-09 16:34 ` Josef Sipek [this message]
2007-02-17 8:56 ` [PATCH 2/2] fs/unionfs/: Remove unused structure members & macros Josef 'Jeff' Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070309163415.GA21427@filer.fsl.cs.sunysb.edu \
--to=jsipek@fsl.cs.sunysb.edu \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox