Re: [stable] [patch 12/20] nfnetlink_log: fix reference counting

Greg KH
2007-03-10T09:15:31Z

On Fri, Mar 09, 2007 at 10:18:03PM -0800, Greg KH wrote:
> -stable review patch. If anyone has any objections, please let us know.
>
> ------------------
> From: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
>
> [NETFILTER]: nfnetlink_log: fix reference counting
>
> Fix reference counting (memory leak) problem in __nfulnl_send() and callers
> related to packet queueing.
>
> Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> ---
> net/netfilter/nfnetlink_log.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/net/netfilter/nfnetlink_log.c
> +++ b/net/netfilter/nfnetlink_log.c
> @@ -220,7 +220,8 @@ _instance_destroy2(struct nfulnl_instanc
> /* timer "holds" one reference (we have one more) */
> if (timer_pending(&inst->timer)) {
> del_timer(&inst->timer);
> - instance_put(inst);
> +
> +instance_put(inst);
> }
> if (inst->qlen)
> __nfulnl_send(inst);
>

As this patch does nothing, it's now dropped. It was my fault as the
original patch didn't apply and I messed up using quilt here.

thanks,

greg k-h