public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Petr Vandrovec <petr@vandrovec.name>
Cc: i2c@lm-sensors.org, Hans-Frieder Vogt <hfvogt@gmx.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add nForce MCP61 support to i2c-nforce2
Date: Sat, 10 Mar 2007 20:29:41 +0100	[thread overview]
Message-ID: <20070310202941.165b28a0.khali@linux-fr.org> (raw)
In-Reply-To: <20070310080003.GA24177@vana.vc.cvut.cz>

Hi Petr,

On Sat, 10 Mar 2007 09:00:03 +0100, Petr Vandrovec wrote:
> Hello,
>   patch below adds support for nVidia's SMBus adapter present on Gateway's GT5414E 
> motherboard (ECS's MCP61 PM-AM).  Patch is for current Linus's git tree.

We already have a patch doing exactly this in -mm:
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3-mm2/broken-out/jdelvare-i2c-i2c-nforce2-add-mcp61-mcp65-support.patch

> 00:01.1 SMBus: nVidia Corporation MCP61 SMBus (rev a2)
>         Subsystem: Elitegroup Computer Systems Unknown device 2601
>         Flags: 66MHz, fast devsel, IRQ 10
>         I/O ports at fc00 [size=64]
>         I/O ports at 1c00 [size=64]
>         I/O ports at f400 [size=64]
>         Capabilities: [44] Power Management version 2

BTW, note how the MCP61 has not 2 but 3 64-byte I/O areas declared. The
previous chips used BAR 4 and 5, this new one additionally uses BAR 0.
Without documentation it's hard to be sure this is a 3rd SMBus channel,
but it sure looks so. Maybe you'll want to hack the i2c-nforce2 driver
a bit to confirm or infirm this theory.

-- 
Jean Delvare

  reply	other threads:[~2007-03-10 19:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-10  8:00 [PATCH] Add nForce MCP61 support to i2c-nforce2 Petr Vandrovec
2007-03-10 19:29 ` Jean Delvare [this message]
2007-03-12  2:08   ` Petr Vandrovec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070310202941.165b28a0.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=hfvogt@gmx.net \
    --cc=i2c@lm-sensors.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petr@vandrovec.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox