sched rsdl fix for 0.28

sched rsdl fix for 0.28

[Con Kolivas]

Here's a big bugfix for sched rsdl 0.28

---
 kernel/sched.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-2.6.21-rc3-mm2/kernel/sched.c
===================================================================
--- linux-2.6.21-rc3-mm2.orig/kernel/sched.c	2007-03-11 11:04:38.000000000 +1100
+++ linux-2.6.21-rc3-mm2/kernel/sched.c	2007-03-11 11:05:46.000000000 +1100
@@ -3328,6 +3328,13 @@ static inline void rotate_runqueue_prior
 	int new_prio_level, remaining_quota = rq_quota(rq, rq->prio_level);
 	struct prio_array *array = rq->active;
 
+	/*
+	 * Make sure we don't have tasks still on the active array that
+	 * haven't run due to not preempting (merging or smp balancing)
+	 */
+	if (find_next_bit(rq->dyn_bitmap, MAX_PRIO, MAX_RT_PRIO) <
+		rq->prio_level)
+			return;
 	if (rq->prio_level > MAX_PRIO - 2) {
 		/* Major rotation required */
 		struct prio_array *new_queue = rq->expired;

-- 
-ck

[BIG] Re: sched rsdl fix for 0.28

[Nicolas Mailhot]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

Le dimanche 11 mars 2007 à 11:07 +1100, Con Kolivas a écrit :
> sched rsdl fix

Doesn't change a thing. Always breaks at the same place (though
depending on hardware timings? the trace is not always the same). Pretty
sure nothing happens before this failure

-- 
Nicolas Mailhot

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [BIG] Re: sched rsdl fix for 0.28

[Con Kolivas]

On Sunday 11 March 2007 20:10, Nicolas Mailhot wrote:
> Le dimanche 11 mars 2007 à 11:07 +1100, Con Kolivas a écrit :
> > sched rsdl fix
>
> Doesn't change a thing. Always breaks at the same place (though
> depending on hardware timings? the trace is not always the same). Pretty
> sure nothing happens before this failure

Bummer. The only other thing to try is v0.29 posted recently. I still haven't 
got a good way to reproduce this locally but I'll keep trying. Thanks for 
testing.

-- 
-ck

Re: [BIG] Re: sched rsdl fix for 0.28

[Con Kolivas]

On Sunday 11 March 2007 20:21, Con Kolivas wrote:
> On Sunday 11 March 2007 20:10, Nicolas Mailhot wrote:
> > Le dimanche 11 mars 2007 à 11:07 +1100, Con Kolivas a écrit :
> > > sched rsdl fix
> >
> > Doesn't change a thing. Always breaks at the same place (though
> > depending on hardware timings? the trace is not always the same). Pretty
> > sure nothing happens before this failure
>
> Bummer. The only other thing to try is v0.29 posted recently. I still
> haven't got a good way to reproduce this locally but I'll keep trying.
> Thanks for testing.

Oh and if that oopses and you still have the time, could you please test 0.29 
on 2.6.20.2 (available from same directory).

-- 
-ck