From: Christoph Hellwig <hch@infradead.org>
To: Dmitriy Monakhov <dmonakhov@sw.ru>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>,
devel@openvz.org
Subject: Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)
Date: Mon, 12 Mar 2007 08:27:19 +0000 [thread overview]
Message-ID: <20070312082719.GC14831@infradead.org> (raw)
In-Reply-To: <878xe2rj0e.fsf@sw.ru>
On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote:
> +/*
> + * Performs necessary checks before doing a write
> + *
> + * Adjust number of segments and amount of bytes to write.
> + * Returns appropriate error code that caller should return or
> + * zero in case that write should be allowed.
> + */
> +inline int generic_segment_checks(const struct iovec *iov,
> + unsigned long *nr_segs, size_t *count,
> + unsigned long access_flags)
Why isn't this static? Also I doubt that we want to inline this function.
next prev parent reply other threads:[~2007-03-12 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 7:57 [PATCH 1/2] mm: move common segment checks to separate helper function (v6) Dmitriy Monakhov
2007-03-12 8:27 ` Christoph Hellwig [this message]
2007-03-12 8:31 ` Nick Piggin
2007-03-12 18:32 ` Dmitriy Monakhov
2007-03-15 21:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312082719.GC14831@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=devel@openvz.org \
--cc=dmonakhov@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox