From: Andi Kleen <andi@firstfloor.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andi Kleen <andi@firstfloor.org>,
"Marcin 'Qrczak' Kowalczyk" <qrczak@knm.org.pl>,
linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: _proxy_pda still makes linking modules fail
Date: Mon, 12 Mar 2007 10:48:05 +0100 [thread overview]
Message-ID: <20070312094805.GA11644@one.firstfloor.org> (raw)
In-Reply-To: <45F49E0A.3090607@goop.org>
On Sun, Mar 11, 2007 at 05:25:46PM -0700, Jeremy Fitzhardinge wrote:
> Andi Kleen wrote:
> > Hmm, it probably needs a EXPORT_SYMBOL. The previous change only
> > fixed the in kernel build.
> >
> > Does it work with this patch?
> >
> > -Andi
> >
> > Export _proxy_pda for gcc 4.2
> >
>
> Gak. It seemed like such a good idea at the time.
The problem is that the upcomming 4.2 has a more aggressive optimizer
and when there are two "m" (_proxy_pda...) references in the same
function it CSEs its address into a register. And that generates
code and a reference.
>
> Rusty's pda->per_cpu patch will deal with this once and for all; have
Not on x86-64.
> you picked it up yet?
Not yet.
-Andi
next prev parent reply other threads:[~2007-03-12 9:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 0:57 _proxy_pda still makes linking modules fail Marcin 'Qrczak' Kowalczyk
2007-03-10 15:03 ` Adrian Bunk
2007-03-11 14:06 ` Marcin 'Qrczak' Kowalczyk
2007-03-12 1:19 ` Andi Kleen
2007-03-12 0:25 ` Jeremy Fitzhardinge
2007-03-12 9:48 ` Andi Kleen [this message]
2007-03-12 14:45 ` Jeremy Fitzhardinge
2007-03-12 15:45 ` Andi Kleen
2007-03-12 21:58 ` Rusty Russell
2007-03-13 6:23 ` Rusty Russell
2007-03-13 9:04 ` Paul Mackerras
2007-03-13 15:31 ` Jeremy Fitzhardinge
2007-03-13 23:50 ` Paul Mackerras
2007-03-14 1:12 ` Rusty Russell
2007-03-13 15:57 ` Andi Kleen
2007-03-14 2:17 ` Rusty Russell
2007-03-12 18:47 ` Marcin 'Qrczak' Kowalczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312094805.GA11644@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qrczak@knm.org.pl \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox