From: Andrew Morton <akpm@linux-foundation.org>
To: Zachary Amsden <zach@vmware.com>
Cc: ak@suse.de, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] Fix vmi time header bug
Date: Mon, 12 Mar 2007 22:31:36 -0800 [thread overview]
Message-ID: <20070312223136.dc6969f3.akpm@linux-foundation.org> (raw)
In-Reply-To: <45F5DB00.1070506@vmware.com>
> On Mon, 12 Mar 2007 14:58:08 -0800 Zachary Amsden <zach@vmware.com> wrote:
> Some gcc put this function in .init.text because the header didn't
> match. For 2.6.21-rc.
>
> Zach
>
>
> [vmi-devinit-header-fix.patch text/plain (606B)]
>
>
> Index: linux-2.6.21/include/asm-i386/vmi_time.h
> ===================================================================
> --- linux-2.6.21.orig/include/asm-i386/vmi_time.h 2007-03-06 18:56:03.000000000 -0800
> +++ linux-2.6.21/include/asm-i386/vmi_time.h 2007-03-12 13:55:16.000000000 -0800
> @@ -54,7 +54,7 @@ extern unsigned long vmi_cpu_khz(void);
>
> #ifdef CONFIG_X86_LOCAL_APIC
> extern void __init vmi_timer_setup_boot_alarm(void);
> -extern void __init vmi_timer_setup_secondary_alarm(void);
> +extern void __devinit vmi_timer_setup_secondary_alarm(void);
> extern void apic_vmi_timer_interrupt(void);
> #endif
Really truly? I think we have a _lot_ of declarations which omit the section
qualifier altogether. How come they don't all break too?
(ARM (at least) in fact does require the section tagging on the declaration as
well as the definition, but we've thus far only fixed that in a couple of places
which were causing breakage).
next prev parent reply other threads:[~2007-03-13 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 22:58 [PATCH] Fix vmi time header bug Zachary Amsden
2007-03-13 6:31 ` Andrew Morton [this message]
2007-03-13 6:21 ` Zachary Amsden
2007-03-13 6:46 ` Zachary Amsden
2007-03-13 12:45 ` Andi Kleen
2007-03-13 13:59 ` Andrew Morton
2007-03-13 17:32 ` Jeremy Fitzhardinge
2007-03-13 17:53 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312223136.dc6969f3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox