From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752515AbXCMAoM (ORCPT ); Mon, 12 Mar 2007 20:44:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752517AbXCMAoL (ORCPT ); Mon, 12 Mar 2007 20:44:11 -0400 Received: from cpe-67-49-92-118.socal.res.rr.com ([67.49.92.118]:48155 "EHLO mail.blackbean.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbXCMAoK (ORCPT ); Mon, 12 Mar 2007 20:44:10 -0400 Date: Mon, 12 Mar 2007 17:41:42 -0700 From: Jim Radford To: Greg KH Cc: Mark Lord , linux-usb-devel@lists.sourceforge.net, Oliver Neukum , Adrian Bunk , Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH] usb-serial regression fix Message-ID: <20070313004142.GA4835@blackbean.org> References: <45F57F63.7010308@rtr.ca> <45F584D9.4090802@rtr.ca> <200703121948.21453.oneukum@suse.de> <45F5B67E.7000105@rtr.ca> <20070312203331.GA6769@kroah.com> <20070312224235.GB3709@blackbean.org> <20070312225922.GA4064@blackbean.org> <20070313001819.GA6147@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070313001819.GA6147@kroah.com> User-Agent: Mutt/1.4.2.2i X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.1.12 (mail.blackbean.org [127.0.0.1]); Mon, 12 Mar 2007 17:41:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 12, 2007 at 05:18:19PM -0700, Greg KH wrote: > On Mon, Mar 12, 2007 at 03:59:22PM -0700, Jim Radford wrote: > > On Mon, Mar 12, 2007 at 03:42:35PM -0700, Jim Radford wrote: > > > On Mon, Mar 12, 2007 at 01:33:31PM -0700, Greg KH wrote: > > > > On Mon, Mar 12, 2007 at 04:22:22PM -0400, Mark Lord wrote: > > > > > Oliver Neukum wrote: > > > > > > >Mark Lord wrote: > > > > > > > >Okay, from that part (above), the problem is obvious: > > > > > > > >in that the "MCT U232 converter now disconnected" > > > > > > > >appears, and then we continue to try and call the > > > > > > > >driver's method.. Oops! > > > > > >IMHO shutdown() is using serial->port[] and bombs. > > > > > >Could you reverse the order here? > > Do not NULL serial->port[i] since it is used in ->shutdown(). > > This wasn't an issue until the order or ->shutdown() and > > device_unregister was corrected. > > for (i = 0; i < serial->num_ports; ++i) > > if (serial->port[i]->dev.parent != NULL) { > > device_unregister(&serial->port[i]->dev); > > - serial->port[i] = NULL; > > } > But shouldn't you null it out somewhere? It will be an "empty" > pointer at some point in time... Not as far as I can see. The serial structure that ->port[i] is in gets kfree()ed soon after, in the same function, and nothing in between, other than ->shutdown(), uses ->port[]. I assume it was someone being overly cautious. -Jim