From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <ak@suse.de>
Cc: zach@vmware.com, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] Fix vmi time header bug
Date: Tue, 13 Mar 2007 05:59:44 -0800 [thread overview]
Message-ID: <20070313055944.bf89eb9b.akpm@linux-foundation.org> (raw)
In-Reply-To: <200703131345.06514.ak@suse.de>
> On Tue, 13 Mar 2007 13:45:06 +0100 Andi Kleen <ak@suse.de> wrote:
> On Tuesday 13 March 2007 07:46, Zachary Amsden wrote:
> > Andrew Morton wrote:
> > > Really truly? I think we have a _lot_ of declarations which omit the
> > > section qualifier altogether. How come they don't all break too?
> >
> > User build was smoking this:
> >
> > make O=build -j16
> >
> > This and non-repeatable results make me suspect some kind of build
> > dependency problem, or perhaps a make bug. Still, please apply, as it
> > doesn't hurt.
>
> I don't think the patch should make any difference, so that's not needed.
>
Correctly matching the section annotation on declarations and definitions
is needed by at least ARM. We should ensure that we do this on all future
patches and we should also apply this patch if only for this reason.
(The ARM thing is a pain, because the compiler cannot check that the
definition and declaration match. However something like sparse could do
so).
next prev parent reply other threads:[~2007-03-13 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 22:58 [PATCH] Fix vmi time header bug Zachary Amsden
2007-03-13 6:31 ` Andrew Morton
2007-03-13 6:21 ` Zachary Amsden
2007-03-13 6:46 ` Zachary Amsden
2007-03-13 12:45 ` Andi Kleen
2007-03-13 13:59 ` Andrew Morton [this message]
2007-03-13 17:32 ` Jeremy Fitzhardinge
2007-03-13 17:53 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070313055944.bf89eb9b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox