Re: [PATCH] Fix vmi time header bug

Andrew Morton
2007-03-13T12:59:55Z

> On Tue, 13 Mar 2007 13:45:06 +0100 Andi Kleen <ak@suse.de> wrote:
> On Tuesday 13 March 2007 07:46, Zachary Amsden wrote:
> > Andrew Morton wrote:
> > > Really truly? I think we have a _lot_ of declarations which omit the
> > > section qualifier altogether. How come they don't all break too?
> >
> > User build was smoking this:
> >
> > make O=build -j16
> >
> > This and non-repeatable results make me suspect some kind of build
> > dependency problem, or perhaps a make bug. Still, please apply, as it
> > doesn't hurt.
>
> I don't think the patch should make any difference, so that's not needed.
>

Correctly matching the section annotation on declarations and definitions
is needed by at least ARM. We should ensure that we do this on all future
patches and we should also apply this patch if only for this reason.

(The ARM thing is a pain, because the compiler cannot check that the
definition and declaration match. However something like sparse could do
so).