Re: [PATCH 00/18] Make common x86 arch area for i386 and x86_64 - Take 2

Adrian Bunk
2007-03-14T18:40:05Z

On Wed, Mar 14, 2007 at 11:36:08AM +0100, Andi Kleen wrote:
> Steven Rostedt <rostedt@goodmis.org> writes:
> >
> > So I spent last night hacking up something to try to make a common ground
> > for all code that is shared between x86_64 and i386. I called this
> >
> > arch/x86
>
> NACK. I think the current ways work just fine.

In my experience, the current situation is a pain in the ass.

There are at least 3 different ways how arch/x86_64/ uses arch/i386/
code [1], and at least 2 different ways how arch/i386/ uses arch/x86_64/

So whenever you touch one file in arch/i386/ or arch/x86_64/, there are
5 different ways how this code could be used from the other architecture.

I'd even suggest the following:
- move all files under arch/x86_64/ that are also used under arch/i386/
to arch/i386/ and then
- mv arch/x86_64 arch/i386/mach-x86_64

The associated Makefile and Kconfig changes shouldn't be a problem, and
after this it will become much easier to see where code gets used.

> -Andi

cu
Adrian

[1] Steven forgot in his list the fifth one:

obj-$(CONFIG_MTRR) += ../../i386/kernel/cpu/mtrr/

The problem with this variant is that different from the
other 4 ways, grep'ing for a filename doesn't find it...

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed