Re: [PATCH 00/18] Make common x86 arch area for i386 and x86_64 - Take 2

Andi Kleen
2007-03-15T16:06:51Z

> That's *exactly* what the patches do (except it's called "arch/x86", which
> is clearly the best option - please don't use "ia" _anywhere_ except for
> "ia64", since that's the only architecture that is really "intel
> architecture").

And i860 @)

> > On the downside, it's more ../../.. type stuff. On the upside,
> > they're more cleanly separated and it's apparent what's going on.
> > Seems nicer to me than drivers/ and kernel/ for stuff that's
> > really arch specific, but shared between two arches.
>
> Absolutely. I'm agreeing violently. I just suspect not a lot of people
> really looked at the patches..

Well I just see a lot of pain from these patches but I doubt
they will avoid any bugs. If people don't compile test both
archs they will always likely break on another. There are lots
of subtle dependencies that are not expressed in the pathname
even after this intrusive operation (e.g. in the includes).

That's just how it is.

If the architecture merging was ever done it would be likely
by extending arch/x86_64 to support (modern) 32bit. But this
change doesn't bring us any step closer to that goal.

I think it's just aesthetics -- i'm all for aesthetics but only
if it gives better software and doesn't impact other people who
want to get something real done; neither of this is the case here.

-Andi