Re: [PATCH 0/2] wistron_btns: More keymaps

Éric Piel
2007-03-14T19:12:13Z

03/14/2007 08:02 PM, Dmitry Torokhov wrote/a écrit:
> On 3/14/07, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>> On 3/14/07, Vojtech Pavlik <vojtech@suse.cz> wrote:
>> > On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote:
>> > > Hi Eric,
>> > >
>> > > 2. I also have a concern about using KEY_SCREEN to signal toggling
>> > > display on and off. I am CCing Vojtech - he must know what the
>> > > original intent of this key code was. BTW, when user presses
>> > > corresponding button - does the display actually goes off? Maybe we
>> > > need another switch.
>> >
>> > Sorry, Dmitry, I probably should have documented it back then, I don't
>> > have the slightest idea anymore.
>> >
>>
>> That's what I was afraid of ;) Well, maybe we should just use it to
>> indicate display switch and add a comment to that effect to input.h...
>>
>
> Oh, wait, DVB uses this code to request switchin full screen mode, we
> better not touch it.
>
Isn't that what is supposed to do KEY_SWITCHVIDEOMODE? Humm... I've got
a feeling that it's not clear where the documentation is or that
documentation is missing ;-)

IIRC, about a month ago someone already asked for precision on the
meaning of some KEY_* . It would probably worth documenting more each
key. More specifically, it could be interesting to decide if the keycode
has to be associated to the physical symbol displayed on the key or
associated to the function that the user (developer) expects when
pressing this key.

Eric