Re: [PATCH 0/2] wistron_btns: More keymaps

Éric Piel
2007-03-20T00:07:19Z

19.03.2007 22:28, Dmitry Torokhov wrote/a écrit:
> On 3/15/07, Éric Piel <Eric.Piel@tremplin-utc.net> wrote:
>>
>> Ok, so let me summarize:
>>
>> There are two kinds of keys on those laptops (for which we are not sure
>> about the keycode that it should generate):
>> * Laptop screen on/off
>> * Display output selection (for instance: laptop/external/both)
>>
>> The possible keycodes that we could assign to them:
>> KEY_SCREEN
>> KEY_MEDIA
>> KEY_MODE
>> KEY_VIDEO
>> KEY_SWITCHVIDEOMODE
>> KEY_COMPUTER
>> KEY_PC
>>
>> From the discussion, I had the feeling this association would be the
>> less incorrect:
>> Screen on/off : KEY_SCREEN
>
> It looks like DVB folks chose to ise KEY_SCREEN and KEY_WINDOW to
> switch applications between full screen and windowed modes
Just for info, I couldn't find any reference to KEY_WINDOW. Anyway,
indeed, KEY_SCREEN is already used for "full screen" (although sometimes
it's KEY_ZOOM :-/) so better not using it if something else is possible.

> so we'll
> have to invent our own keycode. KEY_DISPLAYTOGGLE anyone?
What about KEY_DISPLAYONOFF ? :-)
What should be its value? Would 239 be fine?

>> Display selection : KEY_SWITCHVIDEOMODE
> I agree here.

BTW, I'm thinking of implementing led support. However, there are two
mechanisms for leds in the kernel: the "input layer" leds and the "full
feature" leds. The laptops may have up to three leds: mail, wifi,
bluetooth. The input layer has LED_MAIL but no wifi nor bluetooth. The
led subsystem has the advantage of the very extensible "trigger"
mechanism. Which of the subsystems would you recommend me to use?

See you,
Eric