From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422662AbXCNVLV (ORCPT ); Wed, 14 Mar 2007 17:11:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422663AbXCNVLU (ORCPT ); Wed, 14 Mar 2007 17:11:20 -0400 Received: from server99.tchmachines.com ([72.9.230.178]:35864 "EHLO server99.tchmachines.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422662AbXCNVLT (ORCPT ); Wed, 14 Mar 2007 17:11:19 -0400 X-Greylist: delayed 3320 seconds by postgrey-1.27 at vger.kernel.org; Wed, 14 Mar 2007 17:11:19 EDT Date: Wed, 14 Mar 2007 13:15:42 -0700 From: Ravikiran G Thirumalai To: David Miller Cc: penberg@cs.helsinki.fi, amit2030@gmail.com, linux-kernel@vger.kernel.org, akpm@osdl.org, netdev@vger.kernel.org, shai@scalex86.org, pravin b shelar , "Benzi Galili (Benzi@ScaleMP.com)" Subject: Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value. Message-ID: <20070314201542.GA4192@localhost.localdomain> References: <20070312.135613.78710501.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070312.135613.78710501.davem@davemloft.net> User-Agent: Mutt/1.4.2.1i X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server99.tchmachines.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [47 12] X-AntiAbuse: Sender Address Domain - scalex86.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 12, 2007 at 01:56:13PM -0700, David Miller wrote: > From: Pekka J Enberg > Date: Mon, 12 Mar 2007 14:15:16 +0200 (EET) > > > On 3/9/07, David Miller wrote: > > > The whole cahce-multipath subsystem has to have it's guts revamped for > > > proper error handling. > > > > (Untested patch follows.) > > I'm not accepting untested patches, if people want to fix this > code it cannot be done in a shoddy manner any more, it will > need to be fixed and tested by people who really care about > this code. Hi Dave, We do care for multipath cached option. We do use it often with node aware multipath. We haven't experienced oopsen or crashes for our use cases since the past year. We will test Amit and Pekka's patch with fault injection. We will also go through the core multipath-cached code and give a try at cleaning it up. > > We need real care for this code or I will remove it in 2.6.23 Can you please point us to any open bug reports on multipath cached? We did a Call for testing on netdev sometime back but did not get any bug reports. http://marc.info/?l=linux-netdev&m=114827370231872&w=2 The kernel bugzilla shows zaroo boogs for multipath cached as well. Thanks, Kiran