From: Andi Kleen <ak@suse.de>
To: discuss@x86-64.org
Cc: "Joerg Roedel" <joerg.roedel@amd.com>, linux-kernel@vger.kernel.org
Subject: Re: [discuss] [PATCH] x86_64: fix cpu MHz reporting on constant_tsc cpus
Date: Thu, 15 Mar 2007 00:01:09 +0100 [thread overview]
Message-ID: <200703150001.09390.ak@suse.de> (raw)
In-Reply-To: <20070313100043.GC21463@amd.com>
On Tuesday 13 March 2007 11:00, Joerg Roedel wrote:
> From: Mark Langsdorf <mark.langsdorf@amd.com>
> From: Joerg Roedel <joerg.roedel@amd.com>
>
> This patch fixes the reporting of cpu_mhz in /proc/cpuinfo on CPUs with
> a constant TSC rate and a kernel with disabled cpufreq.
>
> Signed-off-by: Mark Langsdorf <mark.langsdorf@amd.com>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
>
+ cpu_khz = tsc_khz;
+ if (cpu_has(&boot_cpu_data, X86_FEATURE_CONSTANT_TSC) &&
+ nmi_known_cpu()) {
+ cpu_khz = tsc_calibrate_cpu_khz();
+ }
I don't think this will do the right thing on Intel CPUs of which tsc_calibrate_cpu_khz()
knows nothing about.
-Andi
next prev parent reply other threads:[~2007-03-14 23:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-13 10:00 [PATCH] x86_64: fix cpu MHz reporting on constant_tsc cpus Joerg Roedel
2007-03-14 23:01 ` Andi Kleen [this message]
2007-03-15 16:50 ` [discuss] " Joerg Roedel
2007-03-16 11:24 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703150001.09390.ak@suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox