From: Andrew Morton <akpm@linux-foundation.org>
To: Klaus Kudielka <klaus.kudielka@gmx.net>
Cc: linux-kernel@vger.kernel.org, ivan@cyclades.com
Subject: Re: [PATCH] fix cyclades.h for x86_64 (and probably others)
Date: Thu, 15 Mar 2007 11:07:08 -0800 [thread overview]
Message-ID: <20070315110708.ed5ca541.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070314215746.GA7781@mars.oe1kib.ampr.org>
> On Wed, 14 Mar 2007 22:57:47 +0100 Klaus Kudielka <klaus.kudielka@gmx.net> wrote:
> at least on x86_64 the present cyclades.h is broken due to the wrong size
> of uclong. This affects, of course, both the kernel and the user-level
> utilities. The symptom is that cyzload refuses to load the firmware.
> I also managed to freeze the machine when unloading the module.
>
> The patch below fixes this in an architecture-independent way.
> I have tested it with 2.6.19 and the driver works fine again with a
> Cyclades-Z on an Athlon 64 X2.
Looks OK, thanks.
It would be nice as a followup patch to simply remove ucchar, uclong and
all that gunk altogether from that driver and just use u8, u16 etc.
But if you decide to do that, please fix your email client first - it is
replacing tabs with spaces.
next prev parent reply other threads:[~2007-03-15 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 21:57 [PATCH] fix cyclades.h for x86_64 (and probably others) Klaus Kudielka
2007-03-15 19:07 ` Andrew Morton [this message]
2007-03-15 23:21 ` Klaus Kudielka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070315110708.ed5ca541.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ivan@cyclades.com \
--cc=klaus.kudielka@gmx.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox