Re: [PATCH 4/5] swsusp: fix error paths in snapshot_open

Pavel Machek
2007-03-20T22:24:43Z

Hi!

> > > We forget to increase device_available if there's an error in
> > > snapshot_open(), so the snapshot device cannot be open at all after
> > > snapshot_open() has returned an error.
> >
> > Actually, this should go to the beggining of series, as it is
> > (non-critical) bugfix.
>
> Well, yes.
>
> I've just kept the original order. OTOH, I don't think it's as urgent as to go
> into 2.6.21 ("been there forever" kind of thing).

No, it is not urgent enough for 2.6.21... But I have secret plan...
trying to push bitmaps+non-bugfixes for swsusp to 2.6.23, and have
swsusp/s2ram stabilize during 2.6.22. Way too much stuff happened in
2.6.21 series.
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html