Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed

Dave Kleikamp
2007-03-14T20:56:46Z

On Wed, 2007-03-14 at 15:58 -0400, Ashif Harji wrote:
> This patch unconditionally calls mark_page_accessed to prevent pages,
> especially for small files, from being evicted from the page cache despite
> frequent access.

I guess the downside to this is if a reader is reading a large file, or
several files, sequentially with a small read size (smaller than
PAGE_SIZE), the pages will be marked active after just one read pass.
My gut says the benefits of this patch outweigh the cost. I would
expect real-world backup apps, etc. to read at least PAGE_SIZE.

Shaggy
--
David Kleikamp
IBM Linux Technology Center