Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed

Nick Piggin
2007-03-15T20:07:52Z

On Thu, Mar 15, 2007 at 03:55:08PM -0400, Ashif Harji wrote:
>
> It sounds like people are happy with the fix suggested by Nick. That fix
> is okay with me as it fixes the problem I am having.
>
> I suspect, however, that by not directly detecting the problematic access
> pattern, where the file is accessed sequentially in small hunks, other
> applications may experience performance problems related to caching. For
> example, if an application frequently and non-sequentially reads from the
> same page. This is especially true for files of size < PAGE_CACHE_SIZE.
> But, I'm not sure if such an access pattern likely.

Well in general we like to help applications that help themselves. It
is actually a good heuristic, surprisingly. If an application randomly
accesses the same page (and there is no write activity going on), then
it would be better off to cache it in userspace, and if it doesn't care
to do that then it won't mind having to read it off disk now and again :)