Re: do_generic_mapping_read performance issue

Jan Kara
2007-03-13T18:50:17Z

On Tue 13-03-07 14:43:47, Ashif Harji wrote:
>
> >>I would like to submit a patch to fix the performance problem. The
> >>simplest solution is to remove the check. Even in the situation where an
> >>application does not read in PAGE_SIZE multiples as described above, if
> >>the page is accessed frequently it should remain in the cache. However, I
> >>am open to suggestions for a more sophisticated scheme.
> >
> > Well, yes, that's an obvious solution. I just wanted to make sure that
> >such change won't break some other load. But so far it seems it won't...
>
> I would like to find out if the change I am suggesting will cause any
> other problems. Is there someone else I should contact before submitting
> a patch? Or should I just wait another day or two for comments?
I don't think you'll get more feedback now. Just write the patch,
benchmark it with your workload and also some others (basically, there should be
no difference) and then submit the patch together with the performance
numbers and some rationale (if it's your first submission, see
Documentation/SubmittingPatches). Give also CC to Andrew <akpm@linux-foundation.org>
and ask him to put it into -mm kernels for testing.

Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs