From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
ak@suse.de, linux-kernel@vger.kernel.org, eranian@hpl.hp.com,
rdunlap@xenotime.net, Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH] i386: Simplify smp_call_function*() by using common implementation
Date: Fri, 16 Mar 2007 09:32:52 +0100 [thread overview]
Message-ID: <20070316083252.GA21418@elte.hu> (raw)
In-Reply-To: <45F9D5DD.8040909@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Subject: Simplify smp_call_function*() by using common implementation
>
> smp_call_function and smp_call_function_single are almost complete
> duplicates of the same logic. This patch combines them by
> implementing them in terms of the more general
> smp_call_function_mask().
> + /* Send a message to other CPUs */
> + if (cpus_equal(mask, allbutself))
> + send_IPI_allbutself(CALL_FUNCTION_VECTOR);
> + else
> + send_IPI_mask(mask, CALL_FUNCTION_VECTOR);
this is a bit ugly, but i guess we cannot do much about it - the
hardware side handles this in a bit assymetric way too.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2007-03-16 8:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-13 1:12 [PATCH] i386: Simplify smp_call_function*() by using common implementation Jeremy Fitzhardinge
2007-03-15 19:08 ` Andrew Morton
2007-03-15 19:15 ` Jeremy Fitzhardinge
2007-03-15 19:33 ` Andrew Morton
2007-03-15 19:39 ` Jeremy Fitzhardinge
2007-03-15 20:55 ` Andi Kleen
2007-03-15 20:16 ` Jeremy Fitzhardinge
2007-03-15 23:25 ` Jeremy Fitzhardinge
2007-03-16 8:32 ` Ingo Molnar [this message]
2007-03-16 11:26 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070316083252.GA21418@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=eranian@hpl.hp.com \
--cc=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox