public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Korolev, Alexey" <alexey.korolev@intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Linux 2.4.x MTD CFI P30/P33 support
Date: Sat, 17 Mar 2007 07:46:37 +0100	[thread overview]
Message-ID: <20070317064637.GA14739@1wt.eu> (raw)
In-Reply-To: <523F3D8D8C97554AA47E53DF1A05466A666249@nnsmsx411.ccr.corp.intel.com>

Hi Alexey,

On Sat, Mar 17, 2007 at 02:45:13AM +0300, Korolev, Alexey wrote:
> Hello Willy,
> 
> The following patch adds support of P30 and P33 NOR FLASH support in
> Linux 2.4
> This flash is substitution of J3 flash which is widely used it on Linux
> 2.4 kernels. Currently many customers wishing to substitute J3 for P3x
> face issues on Linux 2.4. This patch resolves issues with P3x on all
> generic Linux kernels versions since 2.4.21.
> 
> The patch just allows using minor version "4" in CFI driver. Since
> differences between CFI minor version "3" and minor version "4" are
> small the CFI driver is not affected by this. Patch has been verified on
> Mainstone (PXA27x based) platform.

OK, it seems trivial enough to me. I have no problem merging this. Your
mailer has wrapped lines, but I'll fix this by hand.

David, are you OK too ?

Thanks,
Willy

> Signed-off-by: Alexey Korolev <alexey.korolev@intel.com>
> ==================================================
> --- a/drivers/mtd/chips/cfi_cmdset_0001.c	2003-06-13
> 18:51:34.000000000 +0400
> +++ b/drivers/mtd/chips/cfi_cmdset_0001.c	2007-02-16
> 21:39:50.000000000 +0300
> @@ -152,7 +152,7 @@
>  		}
>  		
>  		if (extp->MajorVersion != '1' || 
> -		    (extp->MinorVersion < '0' || extp->MinorVersion >
> '3')) {
> +		    (extp->MinorVersion < '0' || extp->MinorVersion >
> '4')) {
>  			printk(KERN_WARNING "  Unknown IntelExt Extended
> Query "
>  			       "version %c.%c.\n",  extp->MajorVersion,
>  			       extp->MinorVersion);
> ===================================================
> 
> Thanks,
> Alexey

  reply	other threads:[~2007-03-17  6:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-16 23:45 [PATCH] Linux 2.4.x MTD CFI P30/P33 support Korolev, Alexey
2007-03-17  6:46 ` Willy Tarreau [this message]
2007-03-19 17:36   ` akorolev
2007-04-10 17:45     ` akorolev
2007-04-10 20:12       ` Willy Tarreau
     [not found]   ` <45FEC94F.8090006@intel.com>
2007-06-01 14:20     ` [PATCH] SPI FLASH naming conflicts solving akorolev
2007-06-01 17:01       ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070317064637.GA14739@1wt.eu \
    --to=w@1wt.eu \
    --cc=alexey.korolev@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox