Re: [ PATCH] Add suspend/resume for HPET was: Re: [3/6] 2.6.21-rc4: known regressions

Sergei Shtylyov
2007-03-29T13:20:01Z

Hello.

Maxim wrote:

> ---
> This adds support of suspend/resume on i386 for HPET

The part after usually "---" gets cut off, the patch description and
signoff should actially *precede* it.

> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>

> diff --git a/arch/i386/kernel/hpet.c b/arch/i386/kernel/hpet.c
> index 0fd9fba..7c67780 100644
> --- a/arch/i386/kernel/hpet.c
> +++ b/arch/i386/kernel/hpet.c
[...]
> +static __init int hpet_register_sysfs(void)
> +{
> + int err;
> +
> + if (!is_hpet_capable())
> + return 0;
> +
> + err = sysdev_class_register(&hpet_class);
> +
> + if (!err) {
> + sysdev_register(&hpet_device);
> + if (err)
> + sysdev_class_unregister(&hpet_class);

This doesn't make sense, err will always be 0. Perhaps you actually
intended to check the result of sysdev_register()?

> + }
> +
> + return err;
> +}
> +
> +device_initcall(hpet_register_sysfs);
> +
> +#endif

WBR, Sergei