Re: [PATCH v2] Add suspend/resume for HPET

Greg KH
2007-03-31T16:42:04Z

On Sat, Mar 31, 2007 at 06:33:20PM +0200, Thomas Gleixner wrote:
> On Sat, 2007-03-31 at 09:09 -0700, Linus Torvalds wrote:
> >
> > On Sat, 31 Mar 2007, Thomas Gleixner wrote:
> > >
> > > While I agree in principle with the patch, I'm a bit uncomfortable. The
> > > sys device suspend / resume ordering is not guaranteed and relies on the
> > > registering order.
> >
> > Well, this is why we probably should try to get away from the "system
> > device" issue, exactly because system devices are totally outside the
> > normal ordering and only have a random linear order.
> >
> > If the clocksources were actually in the device tree, you'd get all the
> > normal guarantees about hierarchical ordering..
>
> Right, but clock - sources/events need to be extremly late suspended and
> early resumed. How can we ensure this ?

Put it at the top of the device tree.

thanks,

greg k-h