The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: sukadev@us.ibm.com
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
	Cedric Le Goater <clg@fr.ibm.com>,
	Dave Hansen <haveblue@us.ibm.com>,
	Serge Hallyn <serue@us.ibm.com>,
	containers@lists.osdl.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: + remove-the-likelypid-check-in-copy_process.patch added to -mm tree
Date: Sat, 17 Mar 2007 23:50:36 -0700	[thread overview]
Message-ID: <20070318065036.GB32402@us.ibm.com> (raw)
In-Reply-To: <m1bqirlmzw.fsf@ebiederm.dsl.xmission.com>

Eric W. Biederman [ebiederm@xmission.com] wrote:
| Oleg Nesterov <oleg@tv-sign.ru> writes:
| 
| > Yes! I meant we should change INIT_SIGNALS(), currently it does
| >
| > 	#define INIT_SIGNALS(sig) {
| > 		...
| > 		.pgrp           = 1,
| > 		{ .__session      = 1},
| >
| > and this confuses (I think) set_special_pids(1,1) above. Because
| > __set_special_pids() still deals with pid_t, not "struct pid".
| >
| > Unless I missed something, we should kill these 2 initializations
| > above.
| 
| Got it.  I agree we should initialize those fields to 0.
| 
| Sukadev you want to get that?

Sure. Will do that.

Thanks Oleg for your detailed review/comments.

Suka

      reply	other threads:[~2007-03-18  6:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-16 17:02 + remove-the-likelypid-check-in-copy_process.patch added to -mm tree Oleg Nesterov
2007-03-16 18:27 ` Eric W. Biederman
2007-03-17 13:02   ` Oleg Nesterov
2007-03-17 14:04     ` Eric W. Biederman
2007-03-17 15:09       ` Oleg Nesterov
2007-03-17 15:24         ` Oleg Nesterov
2007-03-17 17:01           ` Eric W. Biederman
2007-03-17 17:17             ` Oleg Nesterov
2007-03-17 18:54               ` Eric W. Biederman
2007-03-18  6:50                 ` sukadev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070318065036.GB32402@us.ibm.com \
    --to=sukadev@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=clg@fr.ibm.com \
    --cc=containers@lists.osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=serue@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox