From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965524AbXCSGFJ (ORCPT ); Mon, 19 Mar 2007 02:05:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965632AbXCSGFJ (ORCPT ); Mon, 19 Mar 2007 02:05:09 -0400 Received: from smtp.osdl.org ([65.172.181.24]:43673 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965524AbXCSGFH (ORCPT ); Mon, 19 Mar 2007 02:05:07 -0400 Date: Sun, 18 Mar 2007 22:01:48 -0800 From: Andrew Morton To: Ralf Baechle Cc: Alan Stern , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix build error due to not including Message-Id: <20070318220148.bc223088.akpm@linux-foundation.org> In-Reply-To: <20070319004443.GA25164@linux-mips.org> References: <20070318125808.GA25840@linux-mips.org> <20070319004443.GA25164@linux-mips.org> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Mar 2007 00:44:43 +0000 Ralf Baechle wrote: > On Sun, Mar 18, 2007 at 08:36:48PM -0400, Alan Stern wrote: > > > Acked-by: Alan Stern > > > > Thank you for spotting and fixing this. > > It's the second time I've fixed a CONFIG_SYSFS=n bug. Of course that > sort of thing just shouldn't happen - but the fact that in both cases > the bug wasn't noticed for a few days makes me wonder if we simply should > always enable CONFIG_SYSFS at some point. > If is a bit of a pain to maintain CONFIG_SYSFS=n. But then, it's realtively easy to fix things when they do break, and sysfs does consume rather a lot of memory at runtime. Hopefully someone out there is finding SYSFS=n to be useful for deeply embedded applications.