From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292AbXCSJWs (ORCPT ); Mon, 19 Mar 2007 05:22:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753291AbXCSJWk (ORCPT ); Mon, 19 Mar 2007 05:22:40 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:34817 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753002AbXCSJWP (ORCPT ); Mon, 19 Mar 2007 05:22:15 -0400 Date: Mon, 19 Mar 2007 10:22:18 +0100 From: Adrian Bunk To: Eric.Moore@lsi.com Cc: mpt_linux_developer@lsi.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: drivers/message/fusion/mptscsih.c: inconsequent NULL checking Message-ID: <20070319092218.GH752@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org The Coverity checker spotted the following inconsequent NULL checking in drivers/message/fusion/mptscsih.c: <-- snip --> ... int mptscsih_qcmd(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_cmnd *)) { ... if (vdev && (vdev->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES) && (SCpnt->device->tagged_supported)) { scsictl = scsidir | MPI_SCSIIO_CONTROL_SIMPLEQ; } else { scsictl = scsidir | MPI_SCSIIO_CONTROL_UNTAGGED; } /* Use the above information to set up the message frame */ pScsiReq->TargetID = (u8) vdev->vtarget->id; ... <-- snip --> vdev is first checked but later dereferenced unconditionally. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed