From: Andi Kleen <ak@suse.de>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Trent Waddington <trent.waddington@gmail.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning
Date: Mon, 19 Mar 2007 16:13:04 +0100 [thread overview]
Message-ID: <200703191613.04223.ak@suse.de> (raw)
In-Reply-To: <200703191611.13849.jesper.juhl@gmail.com>
>
> - device_create_file(&floppy_device[drive].dev,&dev_attr_cmos);
> + err = device_create_file(&floppy_device[drive].dev, &dev_attr_cmos);
> + if (err)
> + printk(KERN_WARNING "Unable to create sysfs attribute "
> + "file for floppy device: %s\n",
> + floppy_device[drive].name);
That change looks pretty useless. Either the error should be handled correctly
by bailing out or the warn_unused_results should be dropped.
-Andi
next prev parent reply other threads:[~2007-03-19 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 15:11 [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning Jesper Juhl
2007-03-19 15:13 ` Andi Kleen [this message]
2007-03-19 15:16 ` Jesper Juhl
2007-03-19 15:20 ` Andi Kleen
2007-03-19 17:42 ` Jesper Juhl
-- strict thread matches above, loose matches on Subject: below --
2007-03-20 8:32 Mikael Pettersson
2007-03-20 9:24 ` Jesper Juhl
2007-03-21 7:11 ` Dmitriy Monakhov
2007-03-20 11:29 ` Andreas Kleen
2007-03-20 11:56 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703191613.04223.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trent.waddington@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox