Re: [PATCH] ALPHA: TITAN - check for allocated memory

Al Viro
2007-05-16T19:41:17Z

On Wed, May 16, 2007 at 10:13:32PM +0400, Cyrill Gorcunov wrote:
> This patch adds checking for allocated memory
> which is used to hold AGP info. Also some whitespace
> cleanup.

Could you please not do that again? Whitespace cleanup is nice as a separate
followup, but as it is it just obscures the real changes in patch. Digging
out

> @@ -767,6 +767,11 @@ titan_agp_info(void)
> * Allocate the info structure.
> */
> agp = kmalloc(sizeof(*agp), GFP_KERNEL);
> + if (agp == NULL) {
> + printk(KERN_ERR "TITAN - cannot allocate struct of size %d bytes\n",
> + sizeof(*agp));
> + return NULL;
> + }

out of hundreds of lines in patch just makes review harder. Incidentally,
%d is not size_t, it's int. Use %zu, please.