Re: Oops after cd /sys/.../cpufreq/; rmmod; cat stats/time_in_state

Andrew Morton
2007-03-22T04:11:32Z

On Wed, 21 Mar 2007 21:00:06 -0700 Greg KH <gregkh@suse.de> wrote:

> On Wed, Mar 21, 2007 at 11:51:04PM -0400, Dave Jones wrote:
> > On Wed, Mar 21, 2007 at 08:07:53PM -0700, Greg KH wrote:
> >
> > > > After modprobe/rmmod cpufreq/stats directory appears but doesn't get
> > > > removed. Should it?
> > > Well, one can argue that those stats should never be in sysfs at all
> > > anyway, I mean come on, a histogram in sysfs? That's, not ok.
> >
> > Meh, it's only a cheesy debug thing, so it's not really that big a deal imo.
> > it could probably move to debugfs (we didn't have that when it was merged iirc)
> > I doubt anyone really cares enough to bother though I wouldn't
> > be averse to a patch.
>
> Yeah, I realize this, I'm not trying to find fault, sorry if it came
> across that way. And yes, it should move to debugfs some day, but if it
> does, I'll loose my "what not to put in sysfs" example I use in
> presentations :)
>

I ain't picky, but as a short-term thing it'd be kinda nice if it didn't
oops the kernel.