From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751955AbXCTWBt (ORCPT ); Tue, 20 Mar 2007 18:01:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751958AbXCTWBt (ORCPT ); Tue, 20 Mar 2007 18:01:49 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:52864 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751955AbXCTWBt (ORCPT ); Tue, 20 Mar 2007 18:01:49 -0400 Date: Tue, 20 Mar 2007 23:01:43 +0100 From: Pavel Machek To: "Rafael J. Wysocki" Cc: Andrew Morton , LKML Subject: Re: [PATCH] swsusp: Fix SNAPSHOT_S2RAM ioctl Message-ID: <20070320220143.GI3545@elf.ucw.cz> References: <200703202248.08665.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200703202248.08665.rjw@sisk.pl> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > From: Rafael J. Wysocki > > The SNAPSHOT_S2RAM ioctl does not disable the nonboot CPUs before entering > the suspend, although it should do this. > > } else { > - /* Enter S3, system is already frozen */ > - suspend_enter(PM_SUSPEND_MEM); > - > + error = disable_nonboot_cpus(); > + if (!error) { > + /* Enter S3, system is already frozen */ > + suspend_enter(PM_SUSPEND_MEM); > + enable_nonboot_cpus(); > + } > /* Wake up devices */ > device_resume(); > } Looks ok to me. ACK. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html