Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

Chris Wright
2007-03-16T19:49:11Z

* Jeremy Fitzhardinge (jeremy@goop.org) wrote:
> Ingo Molnar wrote:
> > but only as a cleanup of the current open-coded (void *) casts. My
> > problem with this is that it loses the types. Not that there is much to
> > check for, but still, this adds some assumptions about how function
> > calls look like.
>
> I agree. I don't generally like this kind of hack, but having a single
> test for "func == paravirt_nop" to look for nop pv_ops in the patcher is
> what tipped the balance.

how about __paravirt_nop_start < func < __paravirt_nop_end and preserve
the types?

thanks,
-chris