From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932229AbXCTWtu (ORCPT ); Tue, 20 Mar 2007 18:49:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932274AbXCTWtu (ORCPT ); Tue, 20 Mar 2007 18:49:50 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:55357 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932229AbXCTWts (ORCPT ); Tue, 20 Mar 2007 18:49:48 -0400 From: "Rafael J. Wysocki" To: Pavel Machek Subject: Re: [PATCH 4/5] swsusp: fix error paths in snapshot_open Date: Tue, 20 Mar 2007 23:52:44 +0100 User-Agent: KMail/1.9.5 Cc: Andrew Morton , Peter Zijlstra , LKML References: <200703122214.02657.rjw@sisk.pl> <200703202324.39213.rjw@sisk.pl> <20070320222403.GQ3545@elf.ucw.cz> In-Reply-To: <20070320222403.GQ3545@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703202352.45479.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, 20 March 2007 23:24, Pavel Machek wrote: > Hi! > > > > > We forget to increase device_available if there's an error in > > > > snapshot_open(), so the snapshot device cannot be open at all after > > > > snapshot_open() has returned an error. > > > > > > Actually, this should go to the beggining of series, as it is > > > (non-critical) bugfix. > > > > Well, yes. > > > > I've just kept the original order. OTOH, I don't think it's as urgent as to go > > into 2.6.21 ("been there forever" kind of thing). > > No, it is not urgent enough for 2.6.21... But I have secret plan... > trying to push bitmaps+non-bugfixes for swsusp to 2.6.23, and have > swsusp/s2ram stabilize during 2.6.22. Way too much stuff happened in > 2.6.21 series. OK by me, but I think we'll have to tell Andrew which patches should wait for 2.6.23 anyway. ;-) Rafael