From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] swsusp: Fix SNAPSHOT_S2RAM ioctl
Date: Wed, 21 Mar 2007 09:31:46 +0100 [thread overview]
Message-ID: <20070321083146.GC4520@elf.ucw.cz> (raw)
In-Reply-To: <20070320223109.7158eb9e.akpm@linux-foundation.org>
Hi!
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > The SNAPSHOT_S2RAM ioctl does not disable the nonboot CPUs before entering
> > the suspend, although it should do this.
> >
> > --- linux-2.6.21-rc4.orig/kernel/power/user.c
> > +++ linux-2.6.21-rc4/kernel/power/user.c
> > @@ -374,9 +374,12 @@ static int snapshot_ioctl(struct inode *
> > if (error) {
> > printk(KERN_ERR "Failed to suspend some devices.\n");
> > } else {
> > - /* Enter S3, system is already frozen */
> > - suspend_enter(PM_SUSPEND_MEM);
> > -
> > + error = disable_nonboot_cpus();
> > + if (!error) {
> > + /* Enter S3, system is already frozen */
> > + suspend_enter(PM_SUSPEND_MEM);
> > + enable_nonboot_cpus();
> > + }
> > /* Wake up devices */
> > device_resume();
> > }
>
> Do you consider this appropriate to 2.6.21?
Yes, this one is.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2007-03-21 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 21:48 [PATCH] swsusp: Fix SNAPSHOT_S2RAM ioctl Rafael J. Wysocki
2007-03-20 22:01 ` Pavel Machek
2007-03-21 6:31 ` Andrew Morton
2007-03-21 8:31 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321083146.GC4520@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox