public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dave Jones <davej@redhat.com>, Andi Kleen <andi@firstfloor.org>,
	"Robert P. J. Day" <rpjday@mindspring.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH] Delete obsolete RAW driver feature.
Date: Wed, 21 Mar 2007 15:19:52 -0700	[thread overview]
Message-ID: <20070321151952.02b5612d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070320181442.1ae73295@lxorguk.ukuu.org.uk>

On Tue, 20 Mar 2007 18:14:42 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> On Tue, 20 Mar 2007 12:57:36 -0400
> Dave Jones <davej@redhat.com> wrote:
> 
> > On Sun, Mar 18, 2007 at 04:57:57PM +0100, Andi Kleen wrote:
> >  > "Robert P. J. Day" <rpjday@mindspring.com> writes:
> >  > 
> >  > > Delete the allegedly obsolete raw driver feature, which has been
> >  > > marked for death since 2005.
> >  > 
> >  > I think it would be better to replace it with a wrapper
> >  > that forces O_DIRECT and opens the underlying block device.  I suspect 
> >  > just dropping it will break many people's database setups, which is not
> >  > nice.  Widely used admin interfaces should be only broken when 
> >  > there is a very good reason and just "there is a better way now" 
> >  > doesn't seem quite strong enough.
> > 
> > Agreed.  Given how this keeps coming up every few months, lets just
> > remove that from the list..  It's not that a 306 line driver is
> > particularly invasive anyways..
> > 
> > Signed-off-by: Dave Jones <davej@redhat.com>
> 
> Acked-by: Alan Cox <alan@redhat.com>
> 
> This is a user visible API it is therefore not elligable for removal
> anyway

mutter.

We've given people years of notice and _some_ applications have converted
over to open("/dev/sda1", O_DIRECT), as they should.

Sure, it's a small and simple driver (now), so the cost of maintaining it
is low.

But otoh, there's no reason for it to exist, except for userspace
sluggishness.

So we can either give up, or we can push on: put a rude printk in there
somewhere and who knows, maybe in five years time we can finally be rid of
the thing.


  parent reply	other threads:[~2007-03-21 22:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-18 11:59 [PATCH] Delete obsolete RAW driver feature Robert P. J. Day
2007-03-18 15:57 ` Andi Kleen
2007-03-18 15:38   ` Robert P. J. Day
2007-03-20 16:57   ` Dave Jones
2007-03-20 18:14     ` Alan Cox
2007-03-20 18:47       ` Robert P. J. Day
2007-03-21 22:19       ` Andrew Morton [this message]
2007-03-21 23:19         ` Dave Jones
2007-03-21 23:27           ` Andrew Morton
2007-03-21 23:42             ` Dave Jones
2007-03-21 23:56               ` Andrew Morton
2007-03-22  0:10         ` Alan Cox
2007-03-21 23:13           ` Andrew Morton
2007-03-21 23:24             ` Willy Tarreau
2007-03-21 23:43               ` Dave Jones
2007-03-22  4:12                 ` Willy Tarreau
2007-03-22  4:17                   ` Dave Jones
2007-03-22  4:45                     ` Willy Tarreau
2007-03-22  5:02                       ` Dave Jones
2007-03-22  5:53                         ` Willy Tarreau
2007-03-22  6:10                           ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070321151952.02b5612d.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andi@firstfloor.org \
    --cc=bunk@stusta.de \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox