From: Paul Mundt <lethal@linux-sh.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: "Wu, Bryan" <bryan.wu@analog.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/5] Blackfin: blackfin architecture patch update
Date: Thu, 22 Mar 2007 08:42:54 +0900 [thread overview]
Message-ID: <20070321234254.GA17498@linux-sh.org> (raw)
In-Reply-To: <8bd0f97a0703210844u44209fc2k27f8ccf431862557@mail.gmail.com>
On Wed, Mar 21, 2007 at 11:44:27AM -0400, Mike Frysinger wrote:
> On 3/5/07, Paul Mundt <lethal@linux-sh.org> wrote:
> >> +int __init oprofile_arch_init(struct oprofile_operations *ops)
> >> +{
> >> +#ifdef CONFIG_HARDWARE_PM
> >[snip]
> >> +#else
> >> + return -1;
> >> +#endif
> >> +}
> >
> >Uh.. fix your dependencies.
>
> can you elaborate ?
This code does nothing if CONFIG_HARDWARE_PM isn't enabled, so your best
bet is to simply have an op_model_null for the cases where you can't
support the counters and work out the dependencies in the Makefile.
Trying to hack both of these together in one driver is not the way to go.
prev parent reply other threads:[~2007-03-21 23:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 4:14 [PATCH -mm 1/5] Blackfin: blackfin architecture patch update Wu, Bryan
2007-03-03 20:38 ` Arnd Bergmann
2007-03-05 7:13 ` Wu, Bryan
2007-03-03 22:30 ` Arnd Bergmann
2007-03-03 22:50 ` bert hubert
2007-03-03 23:05 ` Arnd Bergmann
2007-03-05 6:54 ` Aubrey Li
2007-03-05 8:47 ` Arnd Bergmann
2007-03-05 9:19 ` Wu, Bryan
2007-03-05 16:43 ` Arnd Bergmann
2007-03-05 7:34 ` Wu, Bryan
2007-03-05 8:10 ` Arnd Bergmann
2007-03-06 2:09 ` Mike Frysinger
2007-03-05 9:23 ` Paul Mundt
2007-03-05 12:32 ` Bernd Schmidt
2007-03-05 12:39 ` Paul Mundt
2007-03-05 13:26 ` Robin Getz
2007-03-05 14:00 ` Paul Mundt
2007-03-05 16:29 ` Robin Getz
2007-03-05 17:32 ` Paul Mundt
2007-03-05 22:06 ` Robin Getz
2007-03-06 2:04 ` Mike Frysinger
2007-03-21 15:44 ` Mike Frysinger
2007-03-21 23:42 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321234254.GA17498@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox