From: Dave Jones <davej@redhat.com>
To: Greg KH <gregkh@suse.de>
Cc: Alexey Dobriyan <adobriyan@sw.ru>,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: Oops after cd /sys/.../cpufreq/; rmmod; cat stats/time_in_state
Date: Wed, 21 Mar 2007 23:51:04 -0400 [thread overview]
Message-ID: <20070322035104.GA17159@redhat.com> (raw)
In-Reply-To: <20070322030753.GB5728@suse.de>
On Wed, Mar 21, 2007 at 08:07:53PM -0700, Greg KH wrote:
> > After modprobe/rmmod cpufreq/stats directory appears but doesn't get
> > removed. Should it?
> Well, one can argue that those stats should never be in sysfs at all
> anyway, I mean come on, a histogram in sysfs? That's, not ok.
Meh, it's only a cheesy debug thing, so it's not really that big a deal imo.
it could probably move to debugfs (we didn't have that when it was merged iirc)
I doubt anyone really cares enough to bother though I wouldn't
be averse to a patch.
To the best of my knowledge, nothing in userspace is relying on that stuff
being present (it'd have to cope with it not being there anyway given its
optional).
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-03-22 3:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 15:30 Oops after cd /sys/.../cpufreq/; rmmod; cat stats/time_in_state Alexey Dobriyan
2007-03-19 20:41 ` Greg KH
2007-03-20 10:06 ` Alexey Dobriyan
2007-03-22 3:07 ` Greg KH
2007-03-22 3:51 ` Dave Jones [this message]
2007-03-22 4:00 ` Greg KH
2007-03-22 4:10 ` Andrew Morton
2007-03-22 17:02 ` [PATCH] fix cpufreq_stats attrs removal Mattia Dongili
2007-03-22 17:14 ` Dave Jones
2007-03-22 17:43 ` Mattia Dongili
2007-03-22 17:50 ` Dave Jones
2007-03-30 8:09 ` Alexey Dobriyan
2007-03-30 18:16 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070322035104.GA17159@redhat.com \
--to=davej@redhat.com \
--cc=adobriyan@sw.ru \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox