Re: [PATCH -mm] Fix lseek on /proc/kcore

Arjan van de Ven
2007-03-22T13:16:55Z

On Thu, 2007-03-22 at 12:56 +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> ---
>
> fs/proc/inode.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- a/fs/proc/inode.c
> +++ b/fs/proc/inode.c
> @@ -167,8 +167,9 @@ static loff_t proc_reg_llseek(struct fil
> llseek = pde->proc_fops->llseek;
> spin_unlock(&pde->pde_unload_lock);
>
> - if (llseek)
> - rv = llseek(file, offset, whence);
> + if (!llseek)
> + llseek = default_llseek;
> + rv = llseek(file, offset, whence);
>

this has potential impact way outside kcore......

did you audit all proc users to see if they can deal with lseek?