From: Andrew Morton <akpm@linux-foundation.org>
To: "Ken Chen" <kenchen@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] cache pipe buf page address for non-highmem arch
Date: Thu, 22 Mar 2007 17:01:22 -0800 [thread overview]
Message-ID: <20070322170122.ee2589a1.akpm@linux-foundation.org> (raw)
In-Reply-To: <b040c32a0703221751x54417524l5237742f345eeda9@mail.gmail.com>
On Thu, 22 Mar 2007 17:51:11 -0700 "Ken Chen" <kenchen@google.com> wrote:
> +#ifdef CONFIG_HIGHMEM
> +#define pipe_kmap kmap
> +#define pipe_kmap_atomic kmap_atomic
> +#else /* CONFIG_HIGHMEM */
> +static inline void *pipe_kmap(struct page *page)
> +{
> + return (void *) page->private;
> +}
> +static inline void *pipe_kmap_atomic(struct page *page, enum km_type type)
> +{
> + pagefault_disable();
> + return pipe_kmap(page);
> +}
> +#endif
If we're going to do this then we should also implement pipe_kunmap_atomic().
Relying upon kunmap_atomic() internals like this is weird-looking, and is fragile
against future changes to kunmap_atomic().
next prev parent reply other threads:[~2007-03-23 1:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 0:51 [patch] cache pipe buf page address for non-highmem arch Ken Chen
2007-03-23 1:01 ` Andrew Morton [this message]
2007-03-24 0:48 ` Ken Chen
2007-03-27 4:15 ` Andrew Morton
2007-03-27 17:47 ` Ken Chen
2007-03-27 22:57 ` Zach Brown
2007-03-28 23:14 ` Andrew Morton
2007-03-28 23:21 ` Zach Brown
2007-03-28 23:34 ` Andrew Morton
2007-03-28 23:48 ` Jeremy Fitzhardinge
2007-03-23 10:14 ` Christoph Hellwig
2007-03-24 1:01 ` Ken Chen
2007-03-24 1:40 ` Benjamin LaHaise
2007-03-27 15:05 ` Andi Kleen
2007-03-27 15:01 ` Andi Kleen
2007-03-27 18:06 ` Ken Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070322170122.ee2589a1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox