From: Dave Jones <davej@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@suse.de>, Alexey Dobriyan <adobriyan@sw.ru>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix cpufreq_stats attrs removal
Date: Thu, 22 Mar 2007 13:14:36 -0400 [thread overview]
Message-ID: <20070322171436.GM15364@redhat.com> (raw)
In-Reply-To: <20070322170201.GP4108@inferi.kami.home>
On Thu, Mar 22, 2007 at 06:02:01PM +0100, Mattia Dongili wrote:
> The problem is cpufreq_stats doesn't know when a cpufreq driver is
> removed and doesn't cleanup. I guess this affects any setup with
> cpufreq_stats.
> The attached patch seems to solve both symptoms and yes... it's quite
> invasive as it introduce one more cpufreq policy notification (REMOVED).
>
> BTW: the patch is against .21-rc4-mm1 but applies with some fuzz to
> 2.6.20 too
Alternatively, as it's just debug functionality, we could just
mark it unsafe for rmmod, which is nastier, but a lot less invasive
to the non-debug code.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-03-22 18:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 15:30 Oops after cd /sys/.../cpufreq/; rmmod; cat stats/time_in_state Alexey Dobriyan
2007-03-19 20:41 ` Greg KH
2007-03-20 10:06 ` Alexey Dobriyan
2007-03-22 3:07 ` Greg KH
2007-03-22 3:51 ` Dave Jones
2007-03-22 4:00 ` Greg KH
2007-03-22 4:10 ` Andrew Morton
2007-03-22 17:02 ` [PATCH] fix cpufreq_stats attrs removal Mattia Dongili
2007-03-22 17:14 ` Dave Jones [this message]
2007-03-22 17:43 ` Mattia Dongili
2007-03-22 17:50 ` Dave Jones
2007-03-30 8:09 ` Alexey Dobriyan
2007-03-30 18:16 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070322171436.GM15364@redhat.com \
--to=davej@redhat.com \
--cc=adobriyan@sw.ru \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox