From: Al Viro <viro@ftp.linux.org.uk>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Tomas M <tomas@slax.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch] [bugfix] loop.c
Date: Fri, 23 Mar 2007 14:56:22 +0000 [thread overview]
Message-ID: <20070323145622.GC4095@ftp.linux.org.uk> (raw)
In-Reply-To: <20070323154809.238d8fe2.dada1@cosmosbay.com>
On Fri, Mar 23, 2007 at 03:48:09PM +0100, Eric Dumazet wrote:
> On Fri, 23 Mar 2007 14:36:05 +0000
> Al Viro <viro@ftp.linux.org.uk> wrote:
>
> > On Fri, Mar 23, 2007 at 03:19:56PM +0100, Eric Dumazet wrote:
> > > I cooked the following patch (untested), feel free to test it.
> >
> > Please, get the cleanup into saner shape. This is too ugly.
>
> out_mem:
> while (nba--)
> blk_cleanup_queue(loop_dev[nba]->lo_queue);
> while (nbl--) {
> put_disk(loop_dev[nbl]->lo_disk);
> kfree(loop_dev[nbl]);
> }
> if (loop_dev_vmalloced)
> vfree(loop_dev);
> else
> kfree(loop_dev);
> unregister_blkdev(LOOP_MAJOR, "loop");
>
>
> What is ugly in this code ?
Your counters. Two loops instead of one (no reason to allocate queues in
a a separate loop). vmalloc conditional on kmalloc failure.
next prev parent reply other threads:[~2007-03-23 14:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 14:04 [patch] [bugfix] loop.c Tomas M
2007-03-23 14:18 ` Jiri Kosina
2007-03-23 14:19 ` Eric Dumazet
2007-03-23 14:25 ` Jiri Kosina
2007-03-23 14:51 ` Eric Dumazet
2007-03-23 19:50 ` Michael Tokarev
2007-03-23 23:18 ` Jiri Kosina
2007-03-23 14:33 ` William Lee Irwin III
2007-03-23 14:36 ` Al Viro
2007-03-23 14:48 ` Eric Dumazet
2007-03-23 14:56 ` Al Viro [this message]
2007-03-23 14:41 ` Christoph Hellwig
2007-03-23 14:49 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070323145622.GC4095@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas@slax.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox