From: Adrian Bunk <bunk@stusta.de>
To: kkeil@suse.de, kai.germaschewski@gmx.de, mac@melware.de
Cc: isdn4linux@listserv.isdn4linux.de, randy.dunlap@oracle.com,
linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] fix ISDN_CAPI<->ISDN_DIVAS
Date: Sat, 24 Mar 2007 14:06:22 +0100 [thread overview]
Message-ID: <20070324130622.GE752@stusta.de> (raw)
Randy Dunlap reported in kernel Bugzilla #8241 the following compile
error with CONFIG_ISDN_CAPI=m, CONFIG_ISDN_DIVAS=y:
<-- snip -->
...
WARNING: "DIVA_DIDD_Read" [drivers/isdn/hardware/eicon/divacapi.ko] undefined!
WARNING: "DIVA_DIDD_Read" [drivers/isdn/hardware/eicon/diva_mnt.ko] undefined!
WARNING: "DIVA_DIDD_Read" [drivers/isdn/hardware/eicon/diva_idi.ko] undefined!
WARNING: "proc_net_eicon" [drivers/isdn/hardware/eicon/diva_idi.ko] undefined!
make[1]: *** [__modpost] Error 1
<-- snip -->
Kconfig contains the following strange thing:
menu "Active Eicon DIVA Server cards"
depends on NET && ISDN && ISDN_CAPI!=n
It seems that except for ISDN_DIVAS_DIVACAPI (that already has a proper
dependency), nothing here actually requires ISDN_CAPI?
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/isdn/Makefile | 2 +-
drivers/isdn/hardware/eicon/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc4-mm1/drivers/isdn/hardware/eicon/Kconfig.old 2007-03-23 21:30:30.000000000 +0100
+++ linux-2.6.21-rc4-mm1/drivers/isdn/hardware/eicon/Kconfig 2007-03-23 21:26:09.000000000 +0100
@@ -3,7 +3,7 @@
#
menu "Active Eicon DIVA Server cards"
- depends on NET && ISDN && ISDN_CAPI!=n
+ depends on NET && ISDN
config CAPI_EICON
bool "Support Eicon cards"
--- linux-2.6.21-rc4-mm1/drivers/isdn/Makefile.old 2007-03-23 21:27:19.000000000 +0100
+++ linux-2.6.21-rc4-mm1/drivers/isdn/Makefile 2007-03-23 21:27:38.000000000 +0100
@@ -4,7 +4,7 @@
obj-$(CONFIG_ISDN_I4L) += i4l/
obj-$(CONFIG_ISDN_CAPI) += capi/
-obj-$(CONFIG_ISDN_CAPI) += hardware/
+obj-$(CONFIG_ISDN) += hardware/
obj-$(CONFIG_ISDN_DIVERSION) += divert/
obj-$(CONFIG_ISDN_DRV_HISAX) += hisax/
obj-$(CONFIG_ISDN_DRV_ICN) += icn/
next reply other threads:[~2007-03-24 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-24 13:06 Adrian Bunk [this message]
2007-03-24 13:49 ` [RFC: 2.6 patch] fix ISDN_CAPI<->ISDN_DIVAS Armin Schindler
2007-03-24 15:08 ` Adrian Bunk
2007-03-29 11:06 ` Armin Schindler
2007-03-29 17:29 ` Adrian Bunk
2007-03-29 18:00 ` Armin Schindler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070324130622.GE752@stusta.de \
--to=bunk@stusta.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox