public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [RFC: 2.6 patch] fix ISDN_CAPI<->ISDN_DIVAS
@ 2007-03-24 13:06 Adrian Bunk
  2007-03-24 13:49 ` Armin Schindler
  0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2007-03-24 13:06 UTC (permalink / raw)
  To: kkeil, kai.germaschewski, mac; +Cc: isdn4linux, randy.dunlap, linux-kernel

Randy Dunlap reported in kernel Bugzilla #8241 the following compile 
error with CONFIG_ISDN_CAPI=m, CONFIG_ISDN_DIVAS=y:

<--  snip  -->

...
WARNING: "DIVA_DIDD_Read" [drivers/isdn/hardware/eicon/divacapi.ko] undefined!
WARNING: "DIVA_DIDD_Read" [drivers/isdn/hardware/eicon/diva_mnt.ko] undefined!
WARNING: "DIVA_DIDD_Read" [drivers/isdn/hardware/eicon/diva_idi.ko] undefined!
WARNING: "proc_net_eicon" [drivers/isdn/hardware/eicon/diva_idi.ko] undefined!
make[1]: *** [__modpost] Error 1

<--  snip  -->


Kconfig contains the following strange thing:

menu "Active Eicon DIVA Server cards"
        depends on NET && ISDN && ISDN_CAPI!=n


It seems that except for ISDN_DIVAS_DIVACAPI (that already has a proper 
dependency), nothing here actually requires ISDN_CAPI?


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/isdn/Makefile               |    2 +-
 drivers/isdn/hardware/eicon/Kconfig |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.21-rc4-mm1/drivers/isdn/hardware/eicon/Kconfig.old	2007-03-23 21:30:30.000000000 +0100
+++ linux-2.6.21-rc4-mm1/drivers/isdn/hardware/eicon/Kconfig	2007-03-23 21:26:09.000000000 +0100
@@ -3,7 +3,7 @@
 #
 
 menu "Active Eicon DIVA Server cards"
-	depends on NET && ISDN && ISDN_CAPI!=n
+	depends on NET && ISDN
 
 config CAPI_EICON
 	bool "Support Eicon cards"
--- linux-2.6.21-rc4-mm1/drivers/isdn/Makefile.old	2007-03-23 21:27:19.000000000 +0100
+++ linux-2.6.21-rc4-mm1/drivers/isdn/Makefile	2007-03-23 21:27:38.000000000 +0100
@@ -4,7 +4,7 @@
 
 obj-$(CONFIG_ISDN_I4L)			+= i4l/
 obj-$(CONFIG_ISDN_CAPI)			+= capi/
-obj-$(CONFIG_ISDN_CAPI)			+= hardware/
+obj-$(CONFIG_ISDN)			+= hardware/
 obj-$(CONFIG_ISDN_DIVERSION)		+= divert/
 obj-$(CONFIG_ISDN_DRV_HISAX)		+= hisax/
 obj-$(CONFIG_ISDN_DRV_ICN)		+= icn/


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2007-03-29 18:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-24 13:06 [RFC: 2.6 patch] fix ISDN_CAPI<->ISDN_DIVAS Adrian Bunk
2007-03-24 13:49 ` Armin Schindler
2007-03-24 15:08   ` Adrian Bunk
2007-03-29 11:06     ` Armin Schindler
2007-03-29 17:29       ` Adrian Bunk
2007-03-29 18:00         ` Armin Schindler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox