Re: [patch 1/3] fix illogical behavior in balance_dirty_pages()

David Chinner
2007-03-27T00:23:41Z

On Mon, Mar 26, 2007 at 01:01:24AM -0800, Andrew Morton wrote:
> On Mon, 26 Mar 2007 10:26:18 +0200 Miklos Szeredi <miklos@szeredi.hu> wrote:
> > Ditto for the case, when there are no more dirty pages destined for
> > this queue.
> >
> > I understand, that this can fill up the memory with under writeback
> > pages, but only if the data sitting in all the device queues is
> > comparable to the total memory. I don't know what the realistic
> > chance of that is but David Chinner convinced me, that it's not
> > something that happens in real life. Quoting him from an earlier
> > mail:
> >
> > | Right, and most ppl don't have enough devices in their system for
> > | this to be a problem. Even those of us that do have enough devices
> > | for this to potentially be a problem usually have enough RAM in
> > | the machine so that it is not a problem....
> >
>
> David is overoptimistic ;)

My excuse is that I have trouble thinking in units of memory smaller
than a GB. ;)

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group